Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports - Laneia & Margaret #23

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Ports - Laneia & Margaret #23

wants to merge 40 commits into from

Conversation

msfinnan
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#16
For each person in your pair, describe something you learned from your partner during this project From Laneia I learned how to change Bootstrap into a different look/feel. Learned from Margaret how to think about where to place state and pass functions.
What was one area of React you gained more clarity on during this assignment? We gained more clarity on how state and how to pass functions between components.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We have different components for the movie cards and the search result cards.
Describe how you handled rentals with React Sent an API post request to the rails API with a movie title and customer ID. The movie title and customer ID are held in state in App, so the user can always see the selected user and movie.
Describe a DOM event your application handled In Search, we use event so when a user starts typing the search is equal to the event.target.value/
Did you use any functional stateless components? What for? Select is a functional component. It doesn't have any state of its own that it needs to hold. Props are passed into the functional component.
Did you use any container components? What for? MovieList and CustomerList fetch movie and customer data and then render individual movies and customers.
Do you have any recommendations on how we could improve this project for the next cohort? Show an example of Rails and React interacting before this project.

msfinnan and others added 30 commits June 24, 2019 14:08
@msfinnan
app set up
8d0291f
@msfinnan
created new component files
1aa77d2
@msfinnan
can show all movies in library in app
6383ffc
@msfinnan
added customer and movie components
d56ee92
@msfinnan
renamed library to MovieList and Customers to CustomerList
0271b66
@msfinnan
working on displaying all customers and all movies
04cb166
@msfinnan
added get requests for customers and movies to the same componentDidM…
5564c98 
…ount
@msfinnan
added React Router to App
1549d29
@msfinnan
react router working and can show all movies or all customers
54f3d19
@msfinnan
added functionality to select customer and select movie
bb8fb8a
@msfinnan
added prop types
bbd69a0
@msfinnan
shows selected customer id and movie id
8c5549c
@msfinnan
displaying selected customer id and name, selected movie id and title
b98d3c0
@msfinnan
can make post request to check out movie to customer
695c158
trying to get search working
f8ce2b1
fixed some bugs, not all
35e021c
fixed display movies bug, still working on rental checkout and search
4d9eb38
add back in selected customer movie display
f9b7fb0
@msfinnan
explored api things, rolled back changes, fixed bug in checkout
83ff668
@msfinnan
checkout movie is working
d7237f4
@msfinnan
added error handling for checkout, gives error if no movie or no user…
8156dff 
… is selected
@msfinnan
error messages and success message added for movie checkout
3738e36
basic search functionality, cannot select from it
aea6904
adding in functions to make add to library from search possible, not …
60b704b 
…working yet
add movie to db works, but need to handle if movie is already in db
77a4afc
fixed bug in select movie
744ee26
added movieLookUp method to MovieList.js
4205a08
moved movie state to app.js
05576d9
movie search if already in database displays message instead of butto…
fbcd021 
…n, need to fix search so do not have to load movies first
search can now load movies independently of clicking movies yay
6b33f2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msfinnan